fix resolving dependencies via nested names

[timriley]

My only thought here would that it'd be worth following a similar approach to dry-auto_inject's name detection code, so we have consistent handling across the two. For that, see https://github.com/dry-rb/dry-auto_inject/blob/045cbd46be4338ad37ac4278b5cd72ad37d76dc8/lib/dry/auto_inject/dependency_map.rb#L42-L47:

  VALID_NAME = /([a-z_][a-zA-Z_0-9]*)$/

  # ...

      def name_for(identifier)
        matched = VALID_NAME.match(identifier.to_s)
        raise DependencyNameInvalid, "name +#{identifier}+ is not a valid Ruby identifier" unless matched

        matched[0]
      end

This approach has two benefits:

• It matches Ruby's syntax rules for valid identifiers
• It's agnostic to the separator character being used, as well as gracefully handling any other kind of unexpected characters

[ermolaev]

Thanks for the clarification, I updated code

[solnic]

FYI Codacy got stuck analysing this PR so let's just ignore it here 🤷🏻

[flash-gordon]

Thank you for this, I'll be merging and doing a few tweaks. For instance, we usually have errors in a separate module and have their names ending with Error (ruby convention more or less)