search

dry-rb / dry-inflector

Inflector for Ruby
https://dry-rb.org/gems/dry-inflector
MIT License
95 stars 15 forks source link

Enrich uncountable dictionary #21

Closed pashagray closed 4 years ago

pashagray commented 6 years ago
  1. Add frequently used words
  2. Move words to separate file
GustavoCaso commented 6 years ago

@PavelTkachenko maybe we could have a separate text file with all the words, that gets loaded by Dictionary::Uncountable.

Thanks for the PR ❤️

GustavoCaso commented 6 years ago

@PavelTkachenko any update regarding the comments?

AMHOL commented 6 years ago

Where is this list from? Some of them don't seem right, for example beer.

flash-gordon commented 4 years ago

I will close this PR. AS has a short list of uncountable words, I don't see why we wouldn't do the same. Our current list includes all the AS exceptions plus adds a few more. If you want to modify it, it's supported via irregular. Besides all this, the suggested list is simply not correct :)