dry-rb / dry-inflector

Inflector for Ruby
https://dry-rb.org/gems/dry-inflector
MIT License
95 stars 15 forks source link

Release of 0.1.0 #5

Closed abinoam closed 6 years ago

abinoam commented 7 years ago

Updated 2017-11-16

See comment https://github.com/dry-rb/dry-inflector/issues/1#issuecomment-343634079 and on.

Then @jodosha can fire a release tomorrow.

solnic commented 6 years ago

Unfortunately #6 and #7 are blockers right now :/

jodosha commented 6 years ago

I've worked on fixes for #6 and #7, which are #10 and #11 respectively. I need your review folks.

@abinoam Would you work on #constantize and #foreign_key?

abinoam commented 6 years ago

I'll have some time this afternoon. I will review PRs and add #constantize and #foreign_key. 👍

abinoam commented 6 years ago

After merging #13 the only blocker for the release will be #7.

@solnic is the current api enough for rom-rb compatibility?

I mean, if you just override "people" pluralization with a block at initialization of the inflector would solve for you?

If so, we could release, and then keep going on the discussion of the more complex api with different set of inflections rules.

solnic commented 6 years ago

I mean, if you just override "people" pluralization with a block at initialization of the inflector would solve for you?

yes it would, I'll verify if specs are passing against dry-inflector master

solnic commented 6 years ago

Looks like we're done. rom-rb specs are green in both main suite and rom-sql.