search

dry-rb / dry-logic

Predicate logic with rule composition
https://dry-rb.org/gems/dry-logic/
MIT License
179 stars 66 forks source link

call methods directly instead of using self[] #24

Closed george-carlin closed 7 years ago

george-carlin commented 7 years ago

As mentioned on gitter ;)

george-carlin commented 7 years ago

For reference, I opened this PR in response to @solnic's comment here: https://gitter.im/dry-rb/chat?at=5812097983a2008d22dbe7e7

On 29 October 2016 at 15:24, Fran Worley notifications@github.com wrote:

@fran-worley commented on this pull request.

Could this be potentially confusing where a predicate has the same name as a standard ruby method?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dry-rb/dry-logic/pull/24#pullrequestreview-6347982, or mute the thread https://github.com/notifications/unsubscribe-auth/ACiI5WKPDgdO5nRunC6VeiV55Ef6CI3nks5q41ccgaJpZM4KkHV3 .

fran-worley commented 7 years ago

Thanks @headstock . Just found that as you sent it. In that case it's lovely, I doubt anyone who might get confused would be digging that deep into dry-logic anyway!

solnic commented 7 years ago

Sweet, thank you :)