Add includes? and excludes? predicates, rename inclusion? and exclusion?

dry-rb / dry-logic

Predicate logic with rule composition

https://dry-rb.org/gems/dry-logic/

MIT License

179 stars 66 forks source link

Closed fran-worley closed 8 years ago

fran-worley commented 8 years ago

Added the new predicates & converted the current exclusion? predicate to avoid having to navigate the predicate_set for performance reasons.

TODO: Confirm naming of predicates

tak1n commented 8 years ago

Looks good to me.

cc @timriley, @AMHOL

timriley commented 8 years ago

This is looking good to me too. I made a note about the naming in the other issue, I reckon we should go ahead with that part too :)

fran-worley commented 8 years ago

Just added a commit to rename the existing predicates and deprecate the old names

timriley commented 8 years ago

Awesome! Would you mind updating dry-v to match this change? Looks like we'll need:

updated error messages in the default .yml file
a new optionsfor method in the error compiler (along with specs)
and an update to check_rules_spec just to use the new non-deprecated name for inclusion

Thanks :)