search

dry-rb / dry-logic

Predicate logic with rule composition
https://dry-rb.org/gems/dry-logic/
MIT License
179 stars 66 forks source link

Rename eql? into eq? and not_eql? into not_eq? #93

Closed casperisfine closed 2 years ago

casperisfine commented 2 years ago

Fix: https://github.com/dry-rb/dry-logic/issues/92

I totally understand that this is a breaking API change but I figured it's worth a try.

dgutov commented 2 years ago

Might not be the best alternative, since for example RSpec takes eq to mean ==.

But the only alternative I can suggest is the third person singular inflection: eqls? and not_eqls?.

solnic commented 2 years ago

How about a more verbose is_eql?(foo) and not_eql?(foo)

dgutov commented 2 years ago

How about a more verbose is_eql?(foo) and not_eql?(foo)

Sounds good to me.

solnic commented 2 years ago

Closing in favor of #98