search

dry-rb / dry-schema

Coercion and validation for data structures
https://dry-rb.org/gems/dry-schema
MIT License
421 stars 110 forks source link

Update config in configure blocks only #431

Closed timriley closed 2 years ago

timriley commented 2 years ago

Update all usages of dry-configurable-provided config so that any changes are made inside configure blocks.

This prepares for the changes in https://github.com/dry-rb/dry-configurable/pull/140.

solnic commented 2 years ago

Oh but this means it should go to dry-schema 2.0.0 :/ Is it possible to actually maintain previous behavior?

timriley commented 2 years ago

Just noting for the record that we discussed over in https://github.com/dry-rb/dry-configurable/pull/140 that we would:

make the type spec change (making them mandatory) and push 2.0 along with the configure change

flash-gordon commented 2 years ago

Should we plan zeitwerk for 2.0 as well? I guess we should.

flash-gordon commented 2 years ago

For the record, I've been running zeitwerk for 2+ months on production without problems

solnic commented 2 years ago

Should we plan zeitwerk for 2.0 as well? I guess we should.

I say yes. Most of the work has been completed. It's a matter of releasing stuff and fixing any potential issues (😅).