search

dry-rb / dry-transaction

Business transaction DSL
http://dry-rb.org/gems/dry-transaction
MIT License
468 stars 55 forks source link

Keep original failed step in presence of around #106

Closed flash-gordon closed 6 years ago

flash-gordon commented 6 years ago

Well, it looks like I fixed this, specs copied from #105

flash-gordon commented 6 years ago

gah, fixed specs

timriley commented 6 years ago

@flash-gordon Thanks for tackling this. Your solution is elegant!

I've rearranged the specs for this a little (I want to start grouping them better by "topic"), and now I'll merge it in.

Thanks you also, @Hugo-Hache, for getting the work on this started!

FWIW, I think I've identified another bug related to nested steps, but I'll open up another PR for that, no need to clutter this one up.

timriley commented 6 years ago

BTW, there was no other bug. Everything is golden :)

timriley commented 6 years ago

And it's out in 0.12.1 🎉

GustavoCaso commented 6 years ago

Thanks, @Hugo-Hache for the work on this subject. Thanks, @flash-gordon for always providing great solutions. Thanks, @timriley for the final touches.

I really like this community ❤️