dry-rb / dry-validation

Validation library with type-safe schemas and rules
https://dry-rb.org/gems/dry-validation
MIT License
1.35k stars 190 forks source link

Error message path for rule with nested params #685

Open aleksandra-stolyar opened 3 years ago

aleksandra-stolyar commented 3 years ago

Describe the bug

The error message from dry-validation for incorrect key nesting in en.yml file for rule with nested params is giving wrong path.

To Reproduce

Consider having such schema and some rule depending on several nested parameters.

params do
  required(:data).hash do
    required(:type).filled(:string)
    required(:attributes).hash do
      ....
      required(:phone_number).maybe(:string)
      required(:phone_number_prefix).maybe(:string)
    end
  end
  .....
end

rule(data: {attributes: [:phone_number, :phone_number_prefix]}) do
  phone_number = ....

  key.failure(:invalid) unless phone_number.valid?
end

I tried different nesting of keys in en.yml, but nothing worked. This was the last edit:

en:
  dry_validation:
    errors:
      rules:
        data:
          attributes:
            phone_number:
              phone_number_prefix:
                invalid: 'is of invalid format'

Which as many other tries was giving this error Dry::Validation::MissingMessageError: Message template for :invalid under "data.attributes.phone_number.phone_number_prefix" was not found for such schema

Expected behavior

Error message with valid path in yml file for such rule or which says that rule name should be written in another way.

Discussion started here: https://discourse.dry-rb.org/t/message-path-for-rule-with-very-nested-params/1257/3

moofkit commented 3 years ago

Hi @aleksandra-stolyar! I think you have an issue with configuration. I was trying to reproduce your bug with this gist

But test is passing for now

$ ruby test.rb
.

Finished in 0.02323 seconds (files took 0.29714 seconds to load)
1 example, 0 failures

You can check this out. Or I miss something?