search

dry-rb / dry-web-roda

Roda integration for dry-web apps
MIT License
119 stars 22 forks source link

Avoid call Kernel#system with numeric values in env #73

Closed alejandrobabio closed 6 years ago

alejandrobabio commented 6 years ago

Kernel#system accepts an env hash with strings as values. This patch intents to ensure that.

alejandrobabio commented 6 years ago

This issue was detected trying to run a migration in heroku. This was my output:

alejandro in /tmp/dwr-todo-example(ruby-2.3.3@dwr9) on master ● λ heroku run bundle exec rake db:migrate
Running bundle exec rake db:migrate on ⬢ immense-mountain-41448... up, run.6507 (Free)
<= db:migrate executed
rake aborted!
TypeError: no implicit conversion of Fixnum into String
/app/Rakefile:91:in `system'
/app/Rakefile:91:in `block (3 levels) in <top (required)>'
/app/Rakefile:80:in `block (2 levels) in <top (required)>'
/app/vendor/bundle/ruby/2.3.0/gems/rake-12.2.1/exe/rake:27:in `<top (required)>'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/cli/exec.rb:74:in `load'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/cli/exec.rb:74:in `kernel_load'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/cli/exec.rb:27:in `run'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/cli.rb:360:in `exec'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/vendor/thor/lib/thor.rb:369:in `dispatch'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/cli.rb:20:in `dispatch'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/vendor/thor/lib/thor/base.rb:444:in `start'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/cli.rb:10:in `start'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/exe/bundle:30:in `block in <top (required)>'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/lib/bundler/friendly_errors.rb:121:in `with_friendly_errors'
/app/vendor/bundle/ruby/2.3.0/gems/bundler-1.15.2/exe/bundle:22:in `<top (required)>'
/app/vendor/bundle/ruby/2.3.0/bin/bundle:22:in `load'
/app/vendor/bundle/ruby/2.3.0/bin/bundle:22:in `<main>'
Tasks: TOP => db:migrate
(See full trace by running task with --trace)

It was because the port of the database url is numeric.

timriley commented 6 years ago

Thanks @alejandrobabio! Merging this now (specs should be right again on master after I made some changes there).