dryark / stf_ios_support

Central repo to connect and document components/repos needed for IOS stf support
Other
153 stars 65 forks source link

Portion of updates go get things building/running with node 19, python3 #118

Open KostyaSha opened 1 year ago

KostyaSha commented 1 year ago

After going through issues/forks/mrs decided to PR my local changes for building stuff.

libimobiledevice splitted to glue module that is required for libusbmuxd.

 brew install --build-from-source --HEAD libimobiledevice-glue.rb
 brew install --build-from-source --HEAD libusbmuxd.rb
 brew install --build-from-source --HEAD libimobiledevice.rb

Probably better to relax node to just node binary, but node 20 had some issues...

go stuff is not perfect, i also added go mod in the root of repo, but i'm not sure that it's the best go way.

PS i think switch repos to git submodules would be better and this can allign code/tools in a working state.

KostyaSha commented 1 year ago

Q about coordinator.go, what is the sense of calling go binary from go binary with json as IPC? Why not call it natively?

nanoscopic commented 1 year ago

Q about coordinator.go, what is the sense of calling go binary from go binary with json as IPC? Why not call it natively?

It is done because if you call it natively it doesn't work.

nanoscopic commented 1 year ago

PS i think switch repos to git submodules would be better and this can align code/tools in a working state.

Git submodules will not be used.

nanoscopic commented 1 year ago

go stuff is not perfect, i also added go mod in the root of repo, but i'm not sure that it's the best go way.

What does adding a go.mod in the root accomplish?