search

drym-org / symex.el

An intuitive way to edit Lisp symbolic expressions ("symexes") structurally in Emacs
Other
271 stars 22 forks source link

Patch to exclude Clojure from tree-sitter handling on Emacs 29 #103

Closed countvajhula closed 1 year ago

countvajhula commented 1 year ago

Summary of Changes

As Emacs 29 ships with Tree Sitter support, which appears to include the Clojure language, Symex uses the tree sitter primitives for Clojure instead of the Lisp primitives which are more mature. This is likely leading to a degraded user experience for such users since Tree Sitter support in Symex is still at an alpha stage. This PR is a quick patch to handle Clojure as a Lisp language instead of as a Tree Sitter language.

Public Domain Dedication

(Why: The freely released, copyright-free work in this repository represents an investment in a better way of doing things called attribution-based economics. Attribution-based economics is based on the simple idea that we gain more by giving more, not by holding on to things that, truly, we could only create because we, in our turn, received from others. As it turns out, an economic system based on attribution -- where those who give more are more empowered -- is significantly more efficient than capitalism while also being stable and fair (unlike capitalism, on both counts), giving it transformative power to elevate the human condition and address the problems that face us today along with a host of others that have been intractable since the beginning. You can help make this a reality by releasing your work in the same way -- freely into the public domain in the simple hope of providing value. Learn more about attribution-based economics at drym.org, tell your friends, do your part.)

countvajhula commented 1 year ago

@tommy-mor Could you please try this branch and see if it fixes #100 and #101 for you? I think this is affecting all Clojure users so I'll merge it as soon as you can confirm that it works 😅

Once it's merged into master, I'll rebase the 2.0-integration branch so that we'll have the changes available there as well.

tommy-mor commented 1 year ago

just tested, works as intended and fixes #101, #100 by reverting to non-ts symex for clojure. I don't think we should close #100 until people weigh in on it, as for tree sitter only languages it still doesn't make sense to me. or at least I think it should be discussed

countvajhula commented 1 year ago

Makes sense, thanks for testing!