search

drym-org / symex.el

An intuitive way to edit Lisp symbolic expressions ("symexes") structurally in Emacs
Other
271 stars 22 forks source link

Shed evil-surround dependency #106

Open countvajhula opened 1 year ago

countvajhula commented 1 year ago

evil-surround is only used for changing surrounding delimiters. As the plan is to have the core Symex functionality not rely on Evil, it would be good to eliminate this dependency, as evil-surround entails a transitive dependency on evil.

devcarbon-com commented 1 year ago

Starting on this now. Do I understand correctly that to work on this I should push changes directly to branch 106-shed-evil-surround-dependency ?

countvajhula commented 1 year ago

Hmm, where did that 106 branch come from, did GitHub create it automatically? Looks like it's based on the master branch instead of the 2.0-integration branch.

I'd actually advise working off of your own fork of Symex, using any branch you like. Then when you're ready (or even before), just create a pull request against the upstream 2.0-integration branch. Here's a workflow I recommend:

Assuming you've cloned the repo from your own fork, your fork should already be configured as the origin remote. You can add an upstream remote:

# create remotes for easy collaboration
$ git remote add upstream git@github.com:drym-org/symex.el.git
# then:
$ git fetch upstream
$ git checkout -b 2.0-integration upstream/2.0-integration
$ git checkout -b shed-evil-surround-dependency

Now you should be on your own shed-evil-surround-dependency branch that's based off of the latest 2.0-integration branch.

After you've made some commits, you can:

$ git push origin

... and then you should be able to create the PR on the GitHub UI at any time.