Save point in comment check during deletion

[jezcope]

Summary of Changes

Fixes #143

Public Domain Dedication

• [x] In contributing, I relinquish any copyright claims on my contribution and freely release it into the public domain in the simple hope that it will provide value.

(Why: The freely released, copyright-free work in this repository represents an investment in a better way of doing things called attribution-based economics. Attribution-based economics is based on the simple idea that we gain more by giving more, not by holding on to things that, truly, we could only create because we, in our turn, received from others. As it turns out, an economic system based on attribution -- where those who give more are more empowered -- is significantly more efficient than capitalism while also being stable and fair (unlike capitalism, on both counts), giving it transformative power to elevate the human condition and address the problems that face us today along with a host of others that have been intractable since the beginning. You can help make this a reality by releasing your work in the same way -- freely into the public domain in the simple hope of providing value. Learn more about attribution-based economics at drym.org, tell your friends, do your part.)

[countvajhula]

Thanks for catching this! It looks like this is happening due to a recent change in Evil, specifically this commit -- before that, it works, after that, it has the issue you found. At a glance, I couldn't tell what in that commit might have caused this change in behavior.

It would be preferable to understand what about the upstream change is causing this difference, and whether it is a bug in Symex or a bug in Evil (in which case we should report it there). Are you able to investigate this?

[jezcope]

I can certainly try! 🙂

[countvajhula]

Hi @jezcope , any updates here? If you aren't able to investigate the upstream issue with evil-find-char at the moment, that's totally fine -- I would suggest just adding a comment in the code here to the effect that we are making this change to work around a possible bug in evil-find-char where it sometimes doesn't preserve the initial point position if the character is not found (as, I think, it should). I think that would be sufficient for us to merge this on the Symex end, and with the comment being present in the code, we will remember to follow up later as needed.

[countvajhula]

@jezcope Actually, I'll just go ahead and merge this. Eventually we will be reducing and hopefully eliminating dependency on evil utilities like evil-find-char (e.g. see #118 ), so this should take care of itself at that stage.

Thanks!

[jezcope]

No worries, my intentions and available time did not match up 😅

Thanks!

[countvajhula]

Tell me about it 😅 , thank you for the fix!