search

drym-org / symex.el

An intuitive way to edit Lisp symbolic expressions ("symexes") structurally in Emacs
Other
271 stars 22 forks source link

fix #49: Make move-y direction customizable (and reverse default) #50

Open dalanicolai opened 2 years ago

dalanicolai commented 2 years ago

This commit implements the feature as requested in #49. We imagine the root to be level 0, so that going UP a level corresponds with going DOWN the tree. To eliminate the confusion the function names are changed to go-in/out.

We do not change the functionality of the functions (that would be confusing), but merely flip the keybindings (except for the hydra, no time to set bindings conditionally).

As suggested in one of the comments this commit reverses the default direction.

hxegon commented 2 years ago

Trying to do a PR review on my phone 😅 so apologies if this is already addressed in the code

It looks like this would break compatibilty with peoples custom bindings once this is released. Not super familiar with best elisp practices but I think this could be addressed through aliases?

dalanicolai commented 2 years ago

Good point! I have added the aliases for the commands. For the 'internal' functions, as all occurrences got replaced, their renaming should not cause any issues.

countvajhula commented 1 year ago

Hi @dalanicolai , hope you're well! Just checking in on this PR -- are you still interested in contributing on it? If so, I'd love to get confirmation from you re: placing the code in the public domain. Assuming you are OK with that, it would be great to include this customization in the upcoming 2.0 release. Let me know!