Move ts-specific overlay to dev module for use in the hydra

drym-org / symex.el

An intuitive way to edit Lisp symbolic expressions ("symexes") structurally in Emacs

Other

271 stars 22 forks source link

Move ts-specific overlay to dev module for use in the hydra #54

Closed countvajhula closed 2 years ago

countvajhula commented 2 years ago

Summary of Changes

There was still some leftover overlay code in the ts module which was being used by the hydra used for development. I've moved that over to the dev module.

Public Domain Dedication

[x] In contributing, I relinquish any copyright claims on my contribution and freely release it into the public domain in the simple hope that it will provide value.

polaris64 commented 2 years ago

@countvajhula, I know you requested my review on this PR so I'm just letting you know that I made a comment above (just in case you missed it) :)

countvajhula commented 2 years ago

@polaris64 hmm I still don't see any comments besides your most recent one. Are you sure you mean the present PR and not a different one?

polaris64 commented 2 years ago

@countvajhula that's strange, I can see it but perhaps I accidentally made it invisible to you (I'm not too familiar with reviewing code on GitHub).

Screenshot_20220830-193737

Above is how it appears to me (on my phone at the moment).

countvajhula commented 2 years ago

@polaris64 Oh, weird. My guess is you might have accidentally "started a review" in the GitHub UI, and then the comment doesn't go through unless you click "Finish review". Your other comment "I know you requested ..." was posted as a regular comment instead of as part of a review so it came through immediately.

countvajhula commented 2 years ago

Re: your review comment, now that I'm looking at it, I think I might have removed symex-ts--current-node by mistake assuming that it was symex-ts--current-overlay (which was already removed in the "generalize overlay" PR)! I'll add it back, and sounds like defvar-local is the right choice here so I'll make that change as well.

polaris64 commented 2 years ago

@polaris64 Oh, weird. My guess is you might have accidentally "started a review" in the GitHub UI, and then the comment doesn't go through unless you click "Finish review".

Ah OK, that explains it, yes that's what I did. Sorry for the confusion!