search

dryphp / bitcoin.php

Bitcoin library for PHP.
http://www.nostate.com/3962/bitcoin-php-a-php-library-for-bitcoin/
242 stars 115 forks source link

Expand maintainership of the project #24

Open artob opened 8 years ago

artob commented 8 years ago

As those watching the repo may have noticed, this project now has a permanent new home at https://github.com/dryphp/bitcoin.php. (It previously lived at https://github.com/mikegogulski/bitcoin-php.)

As the original author @mikegogulski has long since moved on to other endeavors, I'm helping hand off commit bits (in a manner similar to the C4 process) to anyone who has significantly contributed to this project previously or has done significant work in their own fork of the project.

Pinging the following folks in particular, in case they'd be interested in folding their work back upstream:

Also CCing @sam2kb, @justmoon, and @globalcitizen, who already had push access, as well as @Dexus, @Mezrin, and @psyvisions, to whom I've extended push access today for their past contributions.

Also notifying @meitar, @DarrellDuane, @parweb, @slawekw, and @bartek6949 who have each previously made at least one commit to a fork of their own.

sskaje commented 8 years ago

I'm glad to contribute on this project, But I really can't remember what I wrote three years ago.

The first thing right now, I feel, is re-design and re-organize this project.

If you need me, just mail me, @ gmail..

artob commented 8 years ago

@sskaje I would have to take a more conservative approach here, given that there do exist contributions in various existing forks that don't require a full rewrite of the project. So as a first step, I'd be looking to merge any such contributions to the master branch, and call that release 1.0.

Now, if there is interest in working on a subsequent release 2.0 that e.g. were to use more modern PHP features and hence needed a re-design, that could of course happen in parallel on another branch.

sskaje commented 8 years ago

@bendiken , my opinion, no change on current code, brand new design. This project hasn't been updated for years, if there is no critical bugs, don't change too much.

If we make changes like you said: One uses old repo may need to change to an updated release, and then change to version 2; One uses any of ours or his own fork may also do these like above, and he may need to merge lots of changes we made.

The version 2 is the new mainstream, upgrading will be encouraged, version 1 can be maintained(maybe as a branch) but only with critical bugs to keep old users work.

This project has existed for such a long time, I think we should have known what functions we should provide and how people uses modern libraries .

I'm not that conservative, sometimes radical, hahah.

sskaje

Dexus commented 8 years ago

:+1:

Grey2k commented 4 years ago

@artob only now saw you mention) I’m ready to contribute and fix some bugs, review MRs and other stuff What is the process ?

artob commented 4 years ago

@Grey2k OK, great. I've sent you an invite for maintainer privileges to this project. Feel free to push fixes and move things forward! :)