search

ds-civic-data / canyon-foot

0 stars 0 forks source link

hw4 review #6

Open CanyonFoot opened 6 years ago

CanyonFoot commented 6 years ago

@giocorti

giocorti commented 6 years ago

  1. I'm confused by the log price vs Dow Jones plots. Was this a part of HW4?

  2. Nice use of an API and nice nice lyric scrapping. Your code is also well documented which is helpful. Maybe nest time you should include a little more info about the API you used and where exactly to access it.

  3. The code for your plots looks neat, and the plots themselves are interesting. However I don't see any of the data import steps in the md file. After looking in the rmd I see where/how you got the data but you somehow suppressed this code chunk so it doesn't appear in the md file.