search

ds125v / moodle-theme_bootstrap_renderers

A developer theme for working on Moodle 2.4/5 renderers that output Bootstrap 3 compatible HTML
15 stars 10 forks source link

Added settings file to theme #11

Closed rbclark closed 11 years ago

rbclark commented 11 years ago

This adds a settings file which allows users to manipulate all of the settings that were previously hard coded into the theme. It does include a random option which overrides all of the settings.

ds125v commented 11 years ago

Just merged this, thanks a lot.

The only change I made was to take out the "jsenabled" body class. That's supposed to be added, via javascript, to indicate that javascript is enabled. Unfortuately I've horribly broken large swathes of the javascript in Moodle by wildly renaming classes and ids. I thought I could fix these as I go, but there's too many of them and they're too difficult to spot when they break, as they generally do so silently or worse, look like they're working because the display changes but then don't save the changes when you leave the page. The current plan is to add back all of those class and id names, purely for the purposes of javascript, which should make most things start working again including, hopefully, the little bit of javascript that adds the jsenabled class to the body. It's a bit untidy, but I can live with it, as the alternative is a whole bunch of work for little gain.

ds125v commented 11 years ago

FYI, I found out why the jsenabled class wasn't being added to the body. I'd inadvertantly deleted the

<?php echo $OUTPUT->standard_top_of_body_html() ?>

line from the layout. It's back in the latest version, and the nav and settings block now expand and collapse properly. Probably fixed a bunch of other odd little issues too.