search

ds300 / derivablejs

Functional Reactive State for JavaScript and TypeScript
Apache License 2.0
515 stars 23 forks source link

version 1.0.0-beta.12 instead of 1.0.0-beta12 #56

Closed wvanderdeijl closed 6 years ago

wvanderdeijl commented 7 years ago

Hi,

We are using the 1.0.0 prerelease versions on our project. In subsequent versions could you please use a dot between the beta prerelease tag and the number? So 1.0.0-beta.12 instead of 1.0.0-beta12

This ensure we can use the following dependency in our package.json:

    "derivable": "^1.0.0-beta.9",

Currently the number is part of the prerelease tag itself, so beta9 is considered newer than beta11 (according to alphabet order)

See https://github.com/npm/node-semver for more info.

ds300 commented 7 years ago

Yes, of course, it makes sense. My apologies if this caused you any problems. I wasn't expecting these beta releases to be around for so long.

On 6 Mar 2017 3:02 pm, "Wilfred van der Deijl" notifications@github.com wrote:

Hi,

We are using the 1.0.0 prerelease versions on our project. In subsequent versions could you please use a dot between the beta prerelease tag and the number? So 1.0.0-beta.12 instead of 1.0.0-beta12

This ensure we can use the following dependency in our package.json:

"derivable": "^1.0.0-beta.9",

Currently the number is part of the prerelease tag itself, so beta9 is considered newer than beta11 (according to alphabet order)

See https://github.com/npm/node-semver for more info.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ds300/derivablejs/issues/56, or mute the thread https://github.com/notifications/unsubscribe-auth/ABL1qT-Qj3V9NqFgt5G6L2q9eap_0NA-ks5rjB_rgaJpZM4MUQjk .

wvanderdeijl commented 7 years ago

Unfortunately the new 1.0.0-beta.12 doesn't really solve the issue. If I have my dependency like ^1.0.0-beta.12 it will still use 1.0.0-beta9 as the prerelease tag beta9 is considered greater than beta. I could get it to work to use a dependency like <1.0.0-beta1 ^1.0.0-beta.12 to get the latest beta release. Downside of this one is that it won't pick up the final 1.0.0 release as I require the beta.x pattern.

I guess there is not much you can do at your end as I think npm no longer allows unpublishing the wrong versions. The only thing you could do is forget about the 1.0.0 range and bump it to 1.0.1-beta.x or 1.1.0-beta.x but that would mean you probably never release a 1.0.0 final.

You can play around with semver at https://runkit.com/wvanderdeijl/58be856b25fc1f0014569583 to see for yourself and try alternatives

TrySound commented 6 years ago

@wvanderdeijl Does this issue matter with 2.0.0-beta.1?