search

ds300 / derivablejs

Functional Reactive State for JavaScript and TypeScript
Apache License 2.0
515 stars 23 forks source link

Flow types improvements #81

Closed TrySound closed 6 years ago

ds300 commented 6 years ago

Thanks again!

TrySound commented 6 years ago

;)

ds300 commented 6 years ago

@TrySound I'm just going to give you push rights. I'd appreciate it if you keep making PRs so I can follow what you're doing, but you can merge them yourself. Really appreciate all the work you're doing :)

TrySound commented 6 years ago

Cool. Thanks to you for this project.

TrySound commented 6 years ago

Btw, @ds300, can you publish beta 1?

ds300 commented 6 years ago

Sure.

ds300 commented 6 years ago

Do you use npm or yarn? I want to make a lockfile.

TrySound commented 6 years ago

I like yarn. It has upgrade-interactive and lockfile merge features.

ds300 commented 6 years ago

Ok I'm going to create a yarn.lock. Also I'm going to restrict the linting to the src folder because it errors for >es5 features and you're using some >es5 features in the tests.

TrySound commented 6 years ago

There is eslint config in test, which extends root config.

ds300 commented 6 years ago

oh. Well it was failing for me. We can sort it out later

ds300 commented 6 years ago

image

TrySound commented 6 years ago

Thanks!