search

ds300 / jetzt

Speed reader extension for chrome
Other
485 stars 124 forks source link

bookmarklet is not working #102

Closed shnk closed 10 years ago

shnk commented 10 years ago

bookmarklet.js is a multiline code whereas one can only paste a single line code in place of link. I made code single line and pasted it in place of link and tried it with latest internet explorer but it did not at all. I may have done something wrong while making it single line.

So I would request you to please provide us single line code.

ds300 commented 10 years ago

This project makes no attempt to be compatible with internet explorer, I'm afraid. Having said that, someone has released a version as a windows app. See #92

peteruithoven commented 10 years ago

Browsers usually put it behind each other, so this should not be the problem. Otherwise, we're working on making to easier to add the bookmarklet: https://github.com/ds300/jetzt/issues/56

Bookmarklet.js should stay multiline, because it's the source file.

And please try another browser before you complain the bookmarklet doesn't work. And if you complain give more information, like the version of your browser.

h0ru5 commented 10 years ago

while I agree that nobody voluntarily wants to take care of mainting to work with IE, it might make sense to have the grunt script uglify the bookmarklet into a delivery version - which is single-line and minified.

I don't know if there are still restrictions on bookmarklet lengths (there used to be), but if not, we could also put everything into one bookmarklet or at least incorporate parts of jetzt (e.g. configuration) into it.