Closed nomicode closed 10 years ago
This is fantastic. :+1: Thank you!
Awesome. Thanks! :bowtie:
Nice! Already live at http://ds300.github.io/jetzt/
Yep. I have submitted this link to HN and Reddit now.
Hopefully get a bit more traffic from it.
the bookmarklet gives an error for me Uncaught SyntaxError: Unexpected end of input
can anyone else confirm this? maybe some bracket missing in the end?
Some upvotes wouldn't hurt:
http://goo.gl/lc16bj http://goo.gl/ZwgZe8
@h0ru5 oh crap, sorry. There was probably a mixup with me working from old files. I can confirm.
seems the quotes are borked
Was unsure what to do about #56. Do you know?
Lemme do a quick PR to fix the quotes here.
you just need to replace all "
with '
inside the link.
its <a href="...">
and inside that ...
there should be no "
yupp, right. took me too long to type that crypto-liguistic haiku
about 56, we could/should use the code for a starter:
<script src="http://code.jquery.com/jquery-1.11.0.min.js"></script>
<script type="text/javascript">
$(function() {
$.get( "bookmarklet.js", function( data ) {
$("#bookmarklet").attr("href",data);
},"text");
});
</script>
This looks very interesting: https://github.com/peteruithoven/jetzt/blob/add-bookmarklet/addbookmarklet.html but I'm not sure about the offline-script, where to get it from (could be I missed a change in the grunt.js)
@peteruithoven, could you send in a PR?
@nslater I love the new Icon. Did you make a high-res version? We could use it for the chrome extension.
Okay! Created #107 to track it.
I'll created a PR for the offline version: https://github.com/ds300/jetzt/pull/109
The only file you might missed was a bookmarklet-offline.js file.
This PR creates a simple static GitHub Pages website for jetzt.
It includes information from the project's
README.md
, formatted in a more site-friendly way, plus a usable bookmarklet link. (This can be updated to the more recent version, once it is finalised.)The site should look like this:
This design is intended to be a reasonable basis for further work, but may require some tweaking.
I have created a
favicon.ico
which I think is better than the current extension icon. If you agree, I can produce extension icons to match.This PR is intended to close issues #77 and #56.