ds300 / jetzt

Speed reader extension for chrome
Other
485 stars 124 forks source link

Create a GitHub Pages website for jetzt #105

Closed nomicode closed 10 years ago

nomicode commented 10 years ago

This PR creates a simple static GitHub Pages website for jetzt.

It includes information from the project's README.md, formatted in a more site-friendly way, plus a usable bookmarklet link. (This can be updated to the more recent version, once it is finalised.)

The site should look like this:

screen shot 2014-03-20 at 20 11 07

This design is intended to be a reasonable basis for further work, but may require some tweaking.

I have created a favicon.ico which I think is better than the current extension icon. If you agree, I can produce extension icons to match.

This PR is intended to close issues #77 and #56.

ds300 commented 10 years ago

This is fantastic. :+1: Thank you!

nomicode commented 10 years ago

Awesome. Thanks! :bowtie:

h0ru5 commented 10 years ago

Nice! Already live at http://ds300.github.io/jetzt/

nomicode commented 10 years ago

Yep. I have submitted this link to HN and Reddit now.

Hopefully get a bit more traffic from it.

h0ru5 commented 10 years ago

the bookmarklet gives an error for me Uncaught SyntaxError: Unexpected end of input can anyone else confirm this? maybe some bracket missing in the end?

nomicode commented 10 years ago

Some upvotes wouldn't hurt:

http://goo.gl/lc16bj http://goo.gl/ZwgZe8

@h0ru5 oh crap, sorry. There was probably a mixup with me working from old files. I can confirm.

h0ru5 commented 10 years ago

image

seems the quotes are borked

nomicode commented 10 years ago

Was unsure what to do about #56. Do you know?

nomicode commented 10 years ago

Lemme do a quick PR to fix the quotes here.

h0ru5 commented 10 years ago

you just need to replace all " with ' inside the link. its <a href="...">and inside that ... there should be no "

h0ru5 commented 10 years ago

yupp, right. took me too long to type that crypto-liguistic haiku

h0ru5 commented 10 years ago

about 56, we could/should use the code for a starter:

<script src="http://code.jquery.com/jquery-1.11.0.min.js"></script>
    <script type="text/javascript">
        $(function() {
            $.get( "bookmarklet.js", function( data ) {
                $("#bookmarklet").attr("href",data);
            },"text");
        });
    </script>

This looks very interesting: https://github.com/peteruithoven/jetzt/blob/add-bookmarklet/addbookmarklet.html but I'm not sure about the offline-script, where to get it from (could be I missed a change in the grunt.js)

@peteruithoven, could you send in a PR?

ds300 commented 10 years ago

@nslater I love the new Icon. Did you make a high-res version? We could use it for the chrome extension.

nomicode commented 10 years ago

Okay! Created #107 to track it.

peteruithoven commented 10 years ago

I'll created a PR for the offline version: https://github.com/ds300/jetzt/pull/109

The only file you might missed was a bookmarklet-offline.js file.