search

ds300 / jetzt

Speed reader extension for chrome
Other
485 stars 124 forks source link

Added context menu support for PDF text selection #116

Closed pratyushmittal closed 10 years ago

pratyushmittal commented 10 years ago

I have tried to add a basic support for PDFs.

Usage:

Open any pdf. Select a text to Spritz read. Right click >> Speed read with JetZt

Please let me know if the code is erroneous or ugly.

h0ru5 commented 10 years ago

LGTM, thank you! It does enable selecting and jetzt-ing text in chrome's pdf viewer and I confirmed it does not change anything on regular web pages

could you state that your contribution can be licensed under Apache 2.0? see #58

h0ru5 commented 10 years ago

@ds300 is it ok if I merge that or do you want that after the coffee-port?

ds300 commented 10 years ago

@pratyushmittal Thanks! Would you like to be in the contributors list in the readme?

@h0ru5 Feel free to merge anything into dev, but continue to make PRs for master. About Apache, I think contributor agreement is implicit now. That's the impression I got from @nslater anyway. I should really read the whole thing...

nomicode commented 10 years ago

Note: we no longer have a contributors list. Contributors show up in the GitHub UX automatically. I've also taken care of adding a CONTRIBUTING.md doc which makes the license stuff explicit.

nomicode commented 10 years ago

Having some issues with this on the following doc:

http://cran.r-project.org/doc/manuals/R-intro.pdf

I select a para, but the option doesn't come up to use jetzt. Do you know why?

pratyushmittal commented 10 years ago

@ds300 & @h0ru5 : Sure, I have no problem with the Apache 2 for the above commit.

@nslater : I guess it is a chrome api issue and related with specific symbols (such as the dash symbol in the given PDF link). Will try to dig more into it.

ds300 commented 10 years ago

Go ahead :+1: On 23 Mar 2014 18:08, "Johannes Hund" notifications@github.com wrote:

@ds300 https://github.com/ds300 is it ok if I merge that or do you want that after the coffee-port?

Reply to this email directly or view it on GitHubhttps://github.com/ds300/jetzt/pull/116#issuecomment-38390818 .