ds300 / jetzt

Speed reader extension for chrome
Other
486 stars 123 forks source link

Changing em-dash Functionality #118

Closed chrisburnell closed 9 years ago

chrisburnell commented 10 years ago

It feels unnatural to have em-dashes ( and --+) displayed on their own, like a word. They do not add information to the sentence and should adhere to the following:

I had to code all day—tiring.

should't become

I
had
to
code
all
day
—
tiring.

but should become

I
had
to
code
all
day—
tiring.

Note: En-dashes () are used differently and should not be treated the same.

Reference: http://www.typogui.de

ds300 commented 10 years ago

this seems like a personal preference thing to me. I find the standalone em dash helps facilitate the context switch. Also, hyphens are currently used at the end of words to signify that the word was too long and had to be split. There is no/not-much visual difference between hyphens and the various dashes if you use a monospace font, so I think I'll leave it alone for now.

You're right about the en dash, thanks for pointing that out. I'll have to modify the tokeniser.

chrisburnell commented 10 years ago

After using this a lot more since submitting the issue, I actually prefer the standalone em dash to what I suggested, even if it makes me look like an idiot (:disappointed: because I like this project) for the reason you stated.

So, I guess, for anyone else who finds the functionality jarring, try it out for longer and see if you change your mind.