search

ds300 / jetzt

Speed reader extension for chrome
Other
485 stars 124 forks source link

Safari CSS and key binding errors #146

Closed thesved closed 9 years ago

thesved commented 9 years ago

The bookmarklet looks like this in safari: jetzt-safari

Keyword bindings aren't working neither: space, up and down keys.

I tried to fix the CSS first, but can't figure out why absolute positioning doesn't work, because that is why the UI part breaks down.

j6k4m8 commented 9 years ago

I don't have Safari so I can't test... But my understanding is that some versions of the browser have very weird bugs with absolute positioning.

ds300 commented 9 years ago

shrug. I don't personally use safari or even jetzt, so won't be investigating this, but you are of course welcome to submit a PR if you figure out the issue.

peteruithoven commented 9 years ago

I don't use Safari either, but I can confirm the issue. It's not that a percentage is used for top?

thesved commented 9 years ago

The problem lies somewhere in the absolute positioning inside a fixed container, since changing .sr-progress -s "bottom: -10px" to "bottom: -80px" puts the progressbar just beneath the box where it should be.

thesved commented 9 years ago

Okay It looks like it was a flexbox issue, I was able to solve it. I send a PR soon.

peteruithoven commented 9 years ago

Nice!