search

ds300 / jetzt

Speed reader extension for chrome
Other
485 stars 124 forks source link

enable top most nodeName #154

Closed gywn closed 8 years ago

gywn commented 8 years ago

Make selectMode::selection's elements' nodeName available for DOM parsing

For instance if a user's selection is [H3, P, P, H3, P, P], the parser will treat them as [P, P, P, P, P, P]. The fix is necessary for enabling customized wraps on block DOM elements like H1~H6 and BLOCKQUOTE while using sibling elements selection.

ds300 commented 8 years ago

Another great PR, thanks! :D

gywn commented 8 years ago

I have several feature commits in my local dev branch, is there anything that you would like to see in a PR?

  1. Font-weight option in option page;
  2. Use {left: "#", right: ""} to wrap H1~H6;
  3. Use {left: "›", right: ""} (U+203A) to wrap BLOCKQUOTE;
  4. Grant paragraph modifiers to DL, UL and OL.
ds300 commented 8 years ago

Yes please! They all sound good :+1: