ds300 / jetzt

Speed reader extension for chrome

Other

485 stars 124 forks source link

Improve options page (realtime display) #85

Closed j6k4m8 closed 10 years ago

j6k4m8 commented 10 years ago

Realtime Options Page Display

A static Jetzt instance shows the UI of the Jetzt view with a realtime-updating font display and colorization.
Light/Dark selection, with choose-your-own-color color input.
Pick your own progress-bar color
Light theme whites out background, dark theme blacks it out
A dummy paragraph color-coded to show the different pause types

Screenshots:

capture

MB6 commented 10 years ago

+1, want this

ds300 commented 10 years ago

this looks awesome! I'm minutes away from completing a dev-master merge which involved lots of refactoring so I'll pull this when that's done. :+1:

j6k4m8 commented 10 years ago

Awesome, thanks! Just added dark-theme support so it's good to go!

h0ru5 commented 10 years ago

:+1: I just thought about adding a test-button in the options page, which will spawn up a reader on a sample text, but your approach is better

ds300 commented 10 years ago

So when I said 'minutes' I meant '6 hours' apparently. I'll do this tomorrow, sorry for the delay.

j6k4m8 commented 10 years ago

No worries — it gave me time to switch the color-picker to something more flexible.

ds300 commented 10 years ago

Hey @j6k4m8 , I just realised you're not in the list of contributors in the readme! Do you mind if I put you in there? Or you could add it to this PR if you like.

j6k4m8 commented 10 years ago

I wasn't sure if there was a specific order / threshold for adding yourself, so I didn't want to step on any toes! Feel free to add, or let me know where to put myself and I can do it as well. Thanks!

j6k4m8 commented 10 years ago

@ds300, should this still be going to dev after that merging business, or should I switch to master now?

ds300 commented 10 years ago

Keep it on dev. master merges are accompanied by some fiddly bits involving the bookmarklet, demo, and now the changelog/version, which I'd like to handle personally for the time being.

I'm actually about to start merging this in, so probably best not to add anything for the next little while.

j6k4m8 commented 10 years ago

I will do my best to resist.

ds300 commented 10 years ago

I'm merged this into my local branch, but I'm not going to push it just yet. Instead I'm going to spend tonight sorting out this custom theme business once and for all. Hang tight.

nomicode commented 10 years ago

I have a few PRs queued up. Should I hold on to them for now?

j6k4m8 commented 10 years ago

Wooooo

nomicode commented 10 years ago

Nice one. Are we okay to make PRs now?

ds300 commented 10 years ago

Yes you are indeed!

nomicode commented 10 years ago

Great, thanks!

On 18 March 2014 07:31, David Sheldrick notifications@github.com wrote:

Yes you are indeed!

Reply to this email directly or view it on GitHubhttps://github.com/ds300/jetzt/pull/85#issuecomment-37903278 .