`Alt-s` problematic with some keyboard setups

[CorvusEtiam]

Jetzt is great extension, but to use it without problems with my current setup (Polish keyboard) I had to change default keybinding to Alt+j on this line.

if (!instructions && ev.altKey && ev.keyCode === 83) { // more code }

It would be great if can change the default keybinding without editing source code. If you don't mind about it, I can even write something like that.

[ds300]

An options page where you can set keybindings and so forth would be most welcome, and definitely a requirement for a published version of jetzt. Before that happens I want to separate out the core jetzt functionality into it's own file and write a cleaner config abstraction. I'll comment here when that's done (some time this weekend probably) and if you still want to have a go at writing a page to set keybindings, that'd be awesome.

[h0ru5]

21 offers at least a workaround by clicking an icon, it would also be a good place to hook up a config page

[ds300]

@Demagogue: The code is now in a state where this can be done. Also many thanks to @h0ru5 for hooking up the browser action!

[BlueDrink9]

Did any progress get made here? I see it mentioned under #69 in the TODO section, but keybindings apparently remain uncustomisable.

[ds300]

Hi! :wave: looks like it's not configurable but you can edit the code at this line: https://github.com/ds300/jetzt/blob/77d03a85aeff272d4fa80e6f8f774370e750d2e0/modules/control.js#L85 to choose which key combination should launch jeztz

[BlueDrink9]

Thank you, that was the documentation I was after. I noticed a couple of other places similar code appeared, like in jetzt-solid.min.js and jetzt.js (lines 4 and 2, but they're huge). Will that affect anything?

[ds300]

hmm probably. I expect you'll need to rebuild the project with 'npm start' after changing the above line.