ds300 / jetzt

Speed reader extension for chrome
Other
485 stars 124 forks source link

options page: use SPA-routing (ng-route) #99

Closed h0ru5 closed 10 years ago

h0ru5 commented 10 years ago

Hi,

i really like the structuring approach of #94 and thought of doing that until I saw you already did it. However a suggestion, low-prio since the use will not notice it (hopefully):

You can use ng-route to split the page into several small files which might be easier for maintainance and merges. I can also send a PR along, but I dont want to make the dev to master merge more complicated and will await that one.

There are also a lot of nice how-tos for routing e.g. here.

h0ru5 commented 10 years ago

Whew! You got 99 problems but contribs ain't one!

ds300 commented 10 years ago

Good idea! I'm actually fiddling with the options page again tonight so I'll add this to my list of plans.

h0ru5 commented 10 years ago

:+1:

ds300 commented 10 years ago

This is done!