ds300 / patch-package

Fix broken node modules instantly 🏃🏽‍♀️💨
MIT License
10.17k stars 283 forks source link

Uniterpretable Error during makePatch #510

Open kumavis opened 5 months ago

kumavis commented 5 months ago
voxel-lerna on  three-upgrade [$!?] via  v20.11.0 
❯ yarn patch-package vkey
patch-package 8.0.0
• Creating temporary folder
• Installing vkey@0.0.2 with yarn

{
  status: 1,
  signal: null,
  output: [
    null,
    <Buffer 1b 5b 33 31 6d 1b 5b 31 6d 55 6e 6b 6e 6f 77 6e 20 53 79 6e 74 61 78 20 45 72 72 6f 72 1b 5b 32 32 6d 1b 5b 33 39 6d 3a 20 55 6e 73 75 70 70 6f 72 74 ... 185 more bytes>,
    <Buffer >
  ],
  pid: 463708,
  stdout: <Buffer 1b 5b 33 31 6d 1b 5b 31 6d 55 6e 6b 6e 6f 77 6e 20 53 79 6e 74 61 78 20 45 72 72 6f 72 1b 5b 32 32 6d 1b 5b 33 39 6d 3a 20 55 6e 73 75 70 70 6f 72 74 ... 185 more bytes>,
  stderr: <Buffer >,
  error: null
}

/home/xyz/Development/voxel-lerna/node_modules/patch-package/dist/makePatch.js:395
        throw e;
        ^
{
  status: 1,
  signal: null,
  output: [
    null,
    Buffer(235) [Uint8Array] [
       27,  91,  51,  49, 109,  27,  91,  49, 109,  85, 110, 107,
      110, 111, 119, 110,  32,  83, 121, 110, 116,  97, 120,  32,
       69, 114, 114, 111, 114,  27,  91,  50,  50, 109,  27,  91,
       51,  57, 109,  58,  32,  85, 110, 115, 117, 112, 112, 111,
      114, 116, 101, 100,  32, 111, 112, 116, 105, 111, 110,  32,
      110,  97, 109, 101,  32,  40,  34,  45,  45, 105, 103, 110,
      111, 114, 101,  45, 115,  99, 114, 105, 112, 116, 115,  34,
       41,  46,  10,  10,  36,  32, 121,  97, 114, 110,  32, 105,
      110, 115, 116,  97,
      ... 135 more items
    ],
    Buffer(0) [Uint8Array] []
  ],
  pid: 463708,
  stdout: Buffer(235) [Uint8Array] [
     27,  91,  51,  49, 109,  27,  91,  49, 109,  85, 110, 107,
    110, 111, 119, 110,  32,  83, 121, 110, 116,  97, 120,  32,
     69, 114, 114, 111, 114,  27,  91,  50,  50, 109,  27,  91,
     51,  57, 109,  58,  32,  85, 110, 115, 117, 112, 112, 111,
    114, 116, 101, 100,  32, 111, 112, 116, 105, 111, 110,  32,
    110,  97, 109, 101,  32,  40,  34,  45,  45, 105, 103, 110,
    111, 114, 101,  45, 115,  99, 114, 105, 112, 116, 115,  34,
     41,  46,  10,  10,  36,  32, 121,  97, 114, 110,  32, 105,
    110, 115, 116,  97,
    ... 135 more items
  ],
  stderr: Buffer(0) [Uint8Array] [],
  error: null
}

Node.js v20.11.0
virginiab10 commented 4 months ago

I'm having the same issue

gvillenave commented 3 months ago

Same issue here, any updates?

duncannz commented 2 months ago

Same issue here, we are no longer able to update any patches

farfromrefug commented 2 months ago

@duncannz @gvillenave @kumavis @virginiab10 the issue is that patch-package does not support newest versions of yarn. Especially those 2 lines https://github.com/ds300/patch-package/blob/master/src/makePatch.ts#L211 and https://github.com/ds300/patch-package/blob/master/src/makePatch.ts#L220 are failing because newest yarn does not support "--ignore-engines" and. "--ignore-scripts". I managed to fix it locally by removing the trycatch and only run install. But that might not be the perfect fix. Someone would need to look at it deeper

williamAstudillo commented 1 month ago

From readme file , "yarn 2+ have native support for patching dependencies via yarn patch. You do not need to use patch-package on these projects."

nateshmbhat commented 1 month ago

facing same issue