Open j-piasecki opened 6 months ago
+1 to this - I noticed the same with --partial
I ran into this, and it seems to work fine in v7.0.0
I also had the same problem with v8.0.0. I tried to patch react-native-screens@3.34.0
and it fails when files are renamed. For reproduction here are two two patch files, one which is failing and the other one without renames:
This can technically be fixed by adding the --no-rename
option to the diff command in https://github.com/ds300/patch-package/blob/c7c63bf80b3c6b8640b933e20229121b4edfc100/src/makePatch.ts#L314-L321
(This is how i created my succeeding patch file btw)
Is there any benefit in keeping "renames", e.g. performance? Or could we simply add this option to fix this bug?
For issues to do with makePatch -> this solution worked for me. It's been a problem since 2021
Description
Patches are successfully applied when they either only modify a specific file or change its name, but fail when doing both at the same time.
Steps to reproduce
patch-package
version: 8.0.0react-native-wiejskie-ziemniaczki
)README.md
tonot-readme.txt
and addA
letter at the end of the file)node_modules
Interestingly, the patch is applied correctly when running
npx patch-package --partial
Here is the patch file that generated error for me:
Workaround
Splitting the patch into two parts seems to be working well, i.e.: one patch just to rename the file and the other to modify the content.