Open elliottkember opened 3 weeks ago
Oops, a side note – turns out the local patch of patch-package doesn't work, because it only applies the patch after installation. This means in CI, when the packages are all checked out fresh, the patch-package patch isn't applied and the warning persists!
I just found out about https://github.com/ds300/patch-package/issues/43 which will make our patches really easy to work with by separating patches from each other. What a great feature!
Unfortunately we have enabled
--error-on-warn
to ensure we keep our patches up to date, and so the warnings we get from multi-patch names causes our builds to break.I've patched patch-package with patch-package locally to skip
+
version patches, to work around this and avoid the warning. I'm sure there are some gotchas with the.includes('+')
syntax I've used here (NPM versions that include the+
character?) but I thought I should submit this as an issue to see whether it could be applied.Here is the diff that solved my problem:
This issue body was partially generated by patch-package ❤️