search

ds300 / react-native-typescript-transformer

Seamlessly use TypeScript with React Native
MIT License
657 stars 50 forks source link

Use metro-bundler #16

Closed comigor closed 7 years ago

comigor commented 7 years ago

Facebook has moved react-native packager to a new repository: https://github.com/facebook/metro-bundler, which is now a dependency of react-native (>=0.46.0-rc.1).

This PR tries to use metro-bundler in its new location, fallbacking to the old location inside react-native, to maintain compatibility with react-native >=0.45

ds300 commented 7 years ago

Thanks for the contribution! I will take a look some time in the next couple of days. One thing I noticed right away is that metro-bundler should not be a peer dependency. That would mean that app authors need to have it explicitly listed in their package.json, but it is provided by react-native which is already a peer dependency.

comigor commented 7 years ago

oh, you're right! fixing it

ds300 commented 7 years ago

Looks great, thanks! Sorry this took me longer than expected to get around to. I'm going to do a tiny syntax clean up after merging.

ds300 commented 7 years ago

Published in 1.1.0 :tada:

comigor commented 7 years ago

Thanks for your work and quick response, @ds300!