Note on allowSyntheticDefaultImports

ds300 / react-native-typescript-transformer

Seamlessly use TypeScript with React Native

MIT License

657 stars 50 forks source link

Note on allowSyntheticDefaultImports #47

Open henrikra opened 6 years ago

henrikra commented 6 years ago

In readme it reads:

This is neccessary until TypeScript implements suport for synthetic default imports in emitted code as well as in the type checker. See Microsoft/TypeScript#9562.

That issue is now closed so I guess the README should change too?

ds300 commented 6 years ago

Yes, thanks for the reminder! First I'll update the transformer to be able to run without babel if TS is >= 2.7

ds300 commented 6 years ago

update on this: Last night I ripped out the babel transform, and ran in to this issue: https://github.com/Microsoft/TypeScript/issues/21621

Once that bug is solved I'll be happy to release react-native-typescript-transformer 2.0 which won't use babel at all and will only support React Native >= 0.52

wip branch over here: https://github.com/ds300/react-native-typescript-transformer/tree/no-babel

henrikra commented 6 years ago

Sounds good!

henrikra commented 6 years ago

@ds300 Looks like the issue is closed? So we are getting rid of babel now? :O

ds300 commented 6 years ago

So so close! :D

Just need to wait for TS 2.9 to drop. Should be any day now 🤞

skellock commented 6 years ago

What a roller coaster.

Babel 7 will support TS! 😮 🎈🎉
but not all of it 😭 💥
Hey, let's remove babel! 😮 🎈🎉
But we can't cuz of a TS bug. 😢 💥
It's fixed!: 😮 🎈🎉
but we have to wait for 2.9 😪💥

You're killing me here David.

ds300 commented 6 years ago

https://twitter.com/typescriptlang/status/1002230349521338368?s=19

🎊💃🕺🎉

Unfortunately I'm busy with non-tech stuff for a few days, but I'll work on a new release ASAP.

JReinhold commented 5 years ago

hey @ds300 , how's the 2.0 coming along? Honestly I'm just unsure if I should set "module": "es2015" in tsconfig or not, based on the info in the README.