search

ds300 / react-native-typescript-transformer

Seamlessly use TypeScript with React Native
MIT License
657 stars 50 forks source link

Can you update source-map to improve performance? #57

Closed sunnylqm closed 6 years ago

sunnylqm commented 6 years ago

https://github.com/mozilla/source-map/blob/master/CHANGELOG.md SourceMapConsumer now uses WebAssembly, which is much faster

ds300 commented 6 years ago

Absolutely!

ds300 commented 6 years ago

I ran into an issue with this and submitted a PR to source-map to fix it https://github.com/mozilla/source-map/pull/330 — will try again once that gets published.

sunnylqm commented 6 years ago

@ds300 Appreciate your quick and nice work! FYI, the new version of source-map was published 2 days ago https://github.com/mozilla/source-map/commit/b2171d58e90e64472b0e858013c0cc5f6772a83d

ds300 commented 6 years ago

Sweet, thanks for the heads up! I'll take a look soon.

ds300 commented 6 years ago

Just published react-native-typescript-transformer@1.2.6 with the new source-map 🎉

ds300 commented 6 years ago

I decided to revert this change. It broke some people's builds already, and would probably break some more in the coming weeks. I don't think the perf improvements from wasm are worth the time and effort required from the people this affects. Maybe I'll try again in a while.