ds300 / react-native-typescript-transformer

Seamlessly use TypeScript with React Native
MIT License
657 stars 55 forks source link

1.2.7 is breaking on Node9+ #64

Closed ygorlazaro closed 6 years ago

ygorlazaro commented 6 years ago

Hi,

this last release is running an error using Node 9. While debugging we saw this error running from our CI, pointing to your lasted release.

My solution was rollback to 1.2.3 version.

ds300 commented 6 years ago

Hi! 👋 Thanks for the report! What was the error message?

ygorlazaro commented 6 years ago

This is the message I got:

output info "fsevents@1.2.4" is an optional dependency and failed compatibility check. Excluding it from installation.
output error react-native-typescript-transformer@1.2.7: The engine "node" is incompatible with this module. Expected version ">=8.0.0".
output error Found incompatible module
output info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
output 19:56:26 [exp] Unable to find an existing exp instance for this directory, starting a new one...
output 19:56:29 [exp] Error: node_modules directory is missing. Please run `npm install` in your project directory.
ygorlazaro commented 6 years ago

I'm using node v9.9.0

ds300 commented 6 years ago

😕🤔 I will look into this tomorrow.

ygorlazaro commented 6 years ago

No problems, man. I'll see if I can help you on this! (English isn't by power) ;)

ygorlazaro commented 6 years ago

@ds300 , is there a reason to use "engineStrict": false? I know you want to mark this as required, since now the lib supports WASM, but can't it just be a warning setting engineStrict as false?

ds300 commented 6 years ago

Yeah I'll do that. I'm pretty sure ">=8.0.0" is correct syntax, so this is really baffling. But I suppose an erroneous warning is better than an erroneous error.

ds300 commented 6 years ago

alright, just publushed 1.2.8 without engineStrict!

ygorlazaro commented 6 years ago

Great, I'll try right now! Thanks!

ygorlazaro commented 6 years ago

It worked. Sorry the delay to answer you