search

ds4dm / Tulip.jl

Interior-point solver in pure Julia
Other
154 stars 20 forks source link

Update Project.toml for Krylov v0.8 #119

Closed amontoison closed 2 years ago

amontoison commented 2 years ago

KrylovSolver{T, S} is now KrylovSolver{T, FC, S} where FC is T or Complex{T}. I added the support of linear systems with complex numbers.

codecov-commenter commented 2 years ago

Codecov Report

Merging #119 (67bc041) into master (686bbde) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   89.01%   89.01%           
=======================================
  Files          43       43           
  Lines        2759     2759           
=======================================
  Hits         2456     2456           
  Misses        303      303

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 686bbde...67bc041. Read the comment docs.

mtanneau commented 2 years ago

@amontoison is complex support breaking w.r.t Krylov v0.7? I see you removed v0.7 from the compat list

amontoison commented 2 years ago

@amontoison is complex support breaking w.r.t Krylov v0.7? I see you removed v0.7 from the compat list

v0.7 doesn't have the KrylovSolvers for all releases (only versions >= 0.7.7). The API was not finalized and the feature of in-place methods was not documented.