ds4dm / Tulip.jl

Interior-point solver in pure Julia
Other
154 stars 20 forks source link

use signbit(x) instead of (x < zero) #121

Closed nsajko closed 1 year ago

nsajko commented 2 years ago

When x isa BigFloat, this prevents an allocation.

codecov-commenter commented 2 years ago

Codecov Report

Merging #121 (a793564) into master (2b055fd) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head a793564 differs from pull request most recent head 00472e2. Consider uploading reports for the commit 00472e2 to get more accurate results

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   89.01%   89.01%           
=======================================
  Files          43       43           
  Lines        2759     2759           
=======================================
  Hits         2456     2456           
  Misses        303      303           
Impacted Files Coverage Δ
src/IPM/HSD/step.jl 94.80% <100.00%> (ø)
src/Presolve/Presolve.jl 94.58% <100.00%> (ø)
src/Presolve/dominated_column.jl 81.05% <100.00%> (ø)
src/Presolve/forcing_row.jl 16.10% <100.00%> (ø)
src/Presolve/free_column_singleton.jl 98.64% <100.00%> (ø)
src/utils.jl 92.85% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b055fd...00472e2. Read the comment docs.