ds4dm / ecole

Extensible Combinatorial Optimization Learning Environments
https://www.ecole.ai
BSD 3-Clause "New" or "Revised" License
325 stars 68 forks source link

Skip observation extraction in terminal states #206

Closed dchetelat closed 3 years ago

dchetelat commented 3 years ago

This pull request avoids computing the observation function in terminal states. Following internal discussion, it also implements the "Justin trick" of temporarily removing time limits while extracting information, for making these steps atomic. (Not currently an issue but could be?) Finally, this PR makes StrongBranchingScores return a vector of size nb_vars rather than nb_cols, which was an issue detected while investigating the above issue.

dchetelat commented 3 years ago

@AntoinePrv I'll let you review the code, maybe you want some stylistic changes? Also, I'll run the code in parallel for the ABB project and I'll check if it solves the segfault, it should.

gasse commented 3 years ago

Thanks !