Make installable shared library

ds4dm / ecole

Extensible Combinatorial Optimization Learning Environments

https://www.ecole.ai

BSD 3-Clause "New" or "Revised" License

319 stars 68 forks source link

Make installable shared library #240

Closed AntoinePrv closed 2 years ago

AntoinePrv commented 3 years ago

Pull request checklist

[x] I have opened an issue to discuss the proposed changes: Partial #136
[x] I have modified/added tests to cover the new changes/features.
[ ] I have modified/added the documentation to cover the new changes/features.
[x] I have ran the tests, checks, and code formatters.

Proposed implementation

AntoinePrv commented 2 years ago

@dchetelat @gasse @jdumouchelle let's get this big changes merged. You can test it with

conda install -c conda-forge/label/ecole_dev 'ecole=0.8.0.dev0'

jdumouchelle commented 2 years ago

@dchetelat @gasse @jdumouchelle let's get this big changes merged. You can test it with
conda install -c conda-forge/label/ecole_dev 'ecole=0.8.0.dev0'

@AntoinePrv I was able to install with both conda and pip with no issues. I also ran some ecole code and everything ran as expected. Do we want to wait for @dchetelat to test it as well or merge now?

dchetelat commented 2 years ago

Fyi I'm a bit overwhelmed with other stuff so it might take some time until I can test it I think