issues
search
ds4dm
/
ecole
Extensible Combinatorial Optimization Learning Environments
https://www.ecole.ai
BSD 3-Clause "New" or "Revised" License
321
stars
68
forks
source link
Remove unnecessary virtual inheritance
#304
Closed
AntoinePrv
closed
2 years ago
AntoinePrv
commented
2 years ago
Pull request checklist
[ ] I have opened an issue to discuss the proposed changes: Fix #XX.
[x] I have modified/added tests to cover the new changes/features.
[ ] I have modified/added the documentation to cover the new changes/features.
[x] I have ran the tests, checks, and code formatters.
Proposed implementation
[x] Remove unnecessary inheritance in reward/observation
[x] Provide type-erased wrapper for data fuctions
[x] Strengthen traits
[x] Remove unnecessary inheritance in dynamics (using mixins)
[ ] ~Provide operator mixins/CRTP for data functions~
Pull request checklist
Proposed implementation