ds4dm / ecole

Extensible Combinatorial Optimization Learning Environments
https://www.ecole.ai
BSD 3-Clause "New" or "Revised" License
326 stars 68 forks source link

Bugfix Khalil 2016 observation features #340

Closed gasse closed 2 years ago

gasse commented 2 years ago

Pull request checklist

Proposed implementation

When computing the Khalil2016 features, some rows were considered active while they were not in the LP. Hence their LP index was -1, and the features of the last LP row were extracted for these rows. Luckily sometimes the last row was not itself active, hence the features were depending on the memory state (uninitialized memory), which resulted in non-deterministic features and was catched in #314