ds4owd-001 / project-Benedict-89

Unveiling Hydrogeological Dynamics: Advanced Statistical Analysis for Sustainable Groundwater Management.
https://ds4owd-001.github.io/project-Benedict-89/
0 stars 0 forks source link

Project feedback and extend to an openwashdata data package #10

Open mianzg opened 2 months ago

mianzg commented 2 months ago

@Benedict-89 Congrats again on accomplishing your capstone project! We are happy that you went through the course with us and applied the skills in the project. I am reviewing your project on "Unveiling Hydrogeological Dynamics; Advanced Statistical Analysis for Sustainable Groundwater Management.". Note that my review does not have any assessment on the writing content of the report, but I did enjoy reading it and learnt new stuff. Please find the detailed feedback in the next section.

mianzg commented 2 months ago

@Benedict-89 This is a really detailed report which I only read on the sections related to data (Sec 3.3 and 3.4)

  1. You have prepared the data well and provided a nice README, however, the dictionary.csv file is empty and it would great if you can work on that!

  2. You do not have tables with summary statistics, that is formatted in the rendered output using a function taught during the course (e.g. kable() function or gt() function). I would like to you turn line 257-275 to be some nice tables!

    
    #summarise
    transformed_data |>
    summarise(
    avg_depth = mean(depth_m, na.rm = TRUE),
    max_pump_rate = max(pump_rate_l_min, na.rm = TRUE),
    min_water_level = min(water_level_m, na.rm = TRUE),
    unique_rock_types = n_distinct(rock_type, na.rm = TRUE),
    total_records = n()
    )

groupby

transformed_data |> group_by(region) |> summarise( count = n(), avg_depth = mean(depth_m, na.rm = TRUE), max_pump_rate = max(pump_rate_l_min, na.rm = TRUE), min_water_level = min(water_level_m, na.rm = TRUE) )


3. Separate code chunks such that each chunk stands for one plot. You currently have all of them in one code chunk. Then provide a label and a caption for each figure in its code chunk, for example, 
```{r}
#| label: fig-scatter-waterlevel
#| fig-cap: "Scatter plot of depth v.s. water level"

# create a scatter plot of Depth vs. Static Water Level
scatter_plot <- transformed_data |>
  ggplot(aes(x = `depth_m`, y = `water_level_m`)) +
  geom_point() +
  labs(title = "Scatter Plot of depth vs. water_level", x = "depth (m)", y = "water_level (m)") +
  theme_minimal()
mianzg commented 2 months ago

@Benedict-89 Furthermore, we would like to have your project and data turning into an openwashdata data package! That means, we will develop an R data package that you will be an author. You and others can directly use a tidy version of the data in R later. Please let us know if you are interested in this! @margauxgo @larnsce

If you are, please follow my first suggestions to revise on the project! We can then discuss the next steps.

Benedict-89 commented 2 weeks ago

Ok Mian

I will try and work on the feedback raised. Thank you

Benedict-89 commented 2 weeks ago

@mianzg I have worked on the feedback you raised. Please check if they are okay.

Thank you