ds4se / chapters

Perspectives on Data Science for Software Engineering
59 stars 33 forks source link

./bener/bayesianNets.md #109

Open andymeneely opened 8 years ago

andymeneely commented 8 years ago

After review, relabel to 'reviewTwo'. After second review, relabel to 'EditorsComment'.

andymeneely commented 8 years ago

Title of chapter

The Bayes Factor in Software Engineering Practice

URL to the chapter

https://github.com/ds4se/chapters/blob/master/bener/bayesianNets.md

Message?

What is the chapter's clear and approachable take away message?

Bayesian networks are uniquely equipped to model causal relationships, which make them good choices for predicting SE data.

Accessible?

Is the chapters written for a generalist audience (no excessive use of technical terminology) with a minimum of diagrams and references?

Yes, it's pretty good for this.

How can it be made more accessible to generalist?

I think an interesting example at the beginning of causal relationships would be good. Most people don't think about such things. Like maybe: low atmospheric pressure causes storms, which in turn increases rainfall; which mean you can predict rainfall better by incorporating domain knowledge (in this case meterology) to individual factors relate to each other.

Size?

Is the chapter the right length?

Yep, right length

Should anything missing be added?

Need some section headers. Really short sections are okay for this kind of format.

Can anything superfluous be removed (e.g. by deleting some section that does not work so well or by using less jargon, less formulae, lees diagrams, less references).?

I could use less on the details of the results so as to focus on the ideas.

What are the aspects of the chapter that authors SHOULD change?

Nothing glaring, just break it up with some headers and fill out the ideas in each section.

Gotta Mantra?

We encouraged (but did not require) the chapter title to be a mantra or something cute/catchy, i.e., some slogan reflecting best practice for data science for SE? If you have suggestion for a better title, please put them here.

If It's Software Engineering, It's (Probably) Bayesian

Best Points

What are the best points of the chapter that the authors should NOT change?

The idea of causal models as opposed to just regular correlations is really the most important idea here.

abramhindle commented 8 years ago

Daryl Posnett reviewed this in this issue: https://github.com/ds4se/chapters/issues/116

lauriew commented 8 years ago

@darylposnett review copied here by @lauriew

Title of chapter

The Bayes Factor in Software Engineering Practice URL to the chapter

https://github.com/ds4se/chapters/blob/master/bener/bayesianNets.md Message?

Bayes Networks are able to model causal relationships which could be useful in software engineering research. Accessible?

In general yes. Perhaps an example of causality may help to elucidate the chapter. Size?

The chapter is not too long, however, The text is dense in places and probably could either be broken up or thinned somewhat. the graph is somewhat complex and is not well explained. The text could be broken up somewhat with section headers and perhaps the graph could be incorporated into an example. Gotta Mantra? Best Points

Clearly causality is a key element. @abramhindle

lauriew commented 8 years ago

@aysebener You now have two reviews. As we said in a prior email, we are asking for new versions of the chapters by January 13.

Here are some comments I made while reading the chapter in addition to the other reviewers: