Review ./abramhindle/energymining.md

arkival commented 8 years ago

Title of chapter

The Perils of Energy Mining: Measure a Bunch, Compare just Once

URL to the chapter

https://github.com/ds4se/chapters/blob/master/abramhindle/energymining.md

Message?

Energy mining presents a unique set of confounds that require careful consideration in SE research.

Accessible?

Generally yes. There are a few references to HTTPx, but I think that this is ok given the intended audience. The one use of jargon that might not come across well to a more general but computer literate audience is the statement "Construct validity almost suffered from an attribution error."

Size?

Overall the length is fine. I don't think adding the reference to the TI chip really adds much. The single example of the WattsUp Pro device is probably sufficient and is relatively jargon free.

Minor: s/noisey/noisy/

Gotta Mantra?

Best Points

The ENERGISE mnemonic and explanation.

lauriew commented 8 years ago

@abramhindle We are still waiting for the second review for your chapter.

Some of my own comments. You say "This is just one of many perils one faces ..." I'm never a fan of the subject of the sentence being "This" (just ask my students). It causes the sentence to be ambiguous. I think you are meaning that the prior sentence is an example of one of the many perils (involving systems being in different states, I believe), since that example is so specific. If you agree, can you revise to be more clear?

A minor comments

Change "3rd-party" to "third-party".
Seems to be a word missing in "The first step to any successful attempt at optimization is to measure what the system before optimization ... "
Change "it's power" to "its power".
Seems to be a word missing in " ... of a method call unless make a benchmark that repeatedly calls it ... "
"only 1/2 of the test runs" ... to "only half of the test runs"

The mnemonic works well for you!

Please keep in mind that we will be asking for authors to please prepare a new version of your paper by January 13 taking the reviewers' feedback into account. Hopefully your second review will show up soon, but the chapter seems to be in good shape. Thanks and happy holidays.

abramhindle commented 8 years ago

I integrated all comments successfully and to the best of my ability. Still waiting for review #2.

lauriew commented 8 years ago

Thanks. I will bug reviewer #2 again.

I hope you had a great holiday!

On Dec 29, 2015, at 1:56 PM, Abram Hindle notifications@github.com wrote:

I integrated all comments successfully and to the best of my ability. Still waiting for review #2 https://github.com/ds4se/chapters/pull/2.

— Reply to this email directly or view it on GitHub https://github.com/ds4se/chapters/issues/115#issuecomment-167853064.

Laurie Williams, PhD North Carolina State University Associate Department Head and Professor, Department of Computer Science 890 Oval Drive, Room 3272 Campus Box 8206 Raleigh, NC 27695-8206

http://collaboration.csc.ncsu.edu/laurie/

ds4se / chapters