ds4se / chapters

Perspectives on Data Science for Software Engineering
60 stars 34 forks source link

Review of "Open from the Beginning" by Earl Barr #123

Open barr opened 8 years ago

barr commented 8 years ago

Review

Title of chapter

Open from the Beginning

URL to the chapter

https://github.com/ds4se/chapters/tree/master/gousiosg/open-from-the-beginning.md

Message?

What is the chapter's clear and approachable take away message?

Just like research papers, data and tooling should be open from the beginning.

Accessible?

This paper is accessible to the generalist.

Size?

This chapter is the right length.

What are the aspects of the chapter that authors SHOULD change?

I, for one, would be interested in reading more technical details about Alitheia and GHTorrent. I am curious to see if I agree with Georgios contention that openness per se is the main reason for the uptake of GHTorrent. Perhaps the tooling used to build GHTorrent is more popular? Georgios writes that GHTorrent grew with its users: this observation would be strengthened if he stated how many external patches, if any, he accepted.

How does GHTorrent compare to Boa?

Copyedits

"We do not show the same jealousy with the artifacts that comprise our research"

Jealousy is inappropriate here. I suggest:

"We are not so zealous with the artifacts..."

"of making our research even more widespread."

A more idiomatic way to phrase this is "of increasing the impact of our research."

"My PhD supervisor,"

Lose the comma:

"My PhD supervisor"

hacky Shell -> hacky shell

"The work is messy and often confuses the reader in terms of what have they done and how they have done."

This quote is agrammatical: the verb to do is transitive and therefore requires an object. Perhaps the actual quote ends with "and who they have done it."? If the actual quote is erroneous, Georgios should consider adding [sic] to signal that the error is in the original quote.

"The experiment seems foley, results somewhat lacking"

'Foley' is not an English word.

The titles are not in title case.

Gotta Mantra?

This chapter is already well-titled.

Best Points

What are the best points of the chapter that the authors should NOT change?

Georgios has built this chapter on two examples which he compares and contrasts. This is an effective rhetorical device that he should retain.

timm commented 8 years ago

Also mentioned in #123 #106 #42