search

ds5110 / faces

3 stars 0 forks source link

non-utility code in utils/confusion around SVC #18

Closed sophiacofone closed 1 year ago

sophiacofone commented 1 year ago

I noticed that the 2 files zw_svc_geometric_value.py and zw_svc_landmarks.py seem to be importing/using/training the SVC model but they are in the util folder. There is also a file eg_svc.py in the src folder that also uses svc. Can someone help me out with the relationship between these 3 files?

Are the first 2 in utils because they are helpers for eg_svc.py, or are they also training the model? Would it be possible to move the model training to the SRC and keep the utils as helpers only, or am I thinking of this wrong?

Thanks!

jhautala commented 1 year ago

Yeah, I think those scripts can and should be moved up to the src directory.