ds5110 / faces

3 stars 0 forks source link

Update cl_bayes.py with GridSearchCV and KNN #25

Closed CCLynch closed 1 year ago

CCLynch commented 1 year ago

I've refactored the 'cl_bayes.py' file to address #20 and added GridSearchCV for some of the models.

I still need to write 'lda.md', and I will probably change the name to reflect that it's multiple bayesian models. I'll start that after this gets merged.

sophiacofone commented 1 year ago

Looks good, thanks for taking on #20 and adding knn, i would be curious to see how knn and these other models due with the euc. distances but that can always be for future work or a side thing.

I agree that the lda.md needs to be written/name changed. Even if you dont want to write it all up right now, it might be nice to add a make target to the makefile and point to it in that file so we can easily reproduce the figures. Otherwise looks good