ds5110 / faces

3 stars 0 forks source link

Notes on pb's notes #34

Closed sophiacofone closed 1 year ago

sophiacofone commented 1 year ago
jhautala commented 1 year ago

I fixed the Makefile but I couldn't reproduce the error with installing requirements from requirements.txt (I created a new conda environment with python 3.10, used pip install -r to install dependencies, and was able to execute make targets). If anyone can dupe his error, I can help troubleshoot, but maybe we should just make it extra clear that file is for reference only.

sophiacofone commented 1 year ago

hmm ok! thanks for testing that!

jhautala commented 1 year ago

I created a conda env file and tested to make sure it works (should address some concern about environment reproducibility).

ZongyuWu97 commented 1 year ago

svc.md fixed

sophiacofone commented 1 year ago

I added additional testing for un normalized vs normalized for log reg and updated the notes: https://github.com/ds5110/faces/pull/36